Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bool vs. int inconsistency in config files #4039

Closed
mc-butler opened this issue Dec 1, 2019 · 6 comments
Closed

Bool vs. int inconsistency in config files #4039

mc-butler opened this issue Dec 1, 2019 · 6 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.24

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4039
Reporter egmont (@egmontkob)

Up until 3 years ago (commit c455037 and a few followup ones) mc used to store config file entries like

shell_patterns=1

but then it was changed to

shell_patterns=true

The switch was incomplete, the "[Layout]" section still contains integers, e.g.:

menubar_visible=1

resulting in an inconsistent use of booleans in the config file.

([HotlistConfig] -> expanded_view_of_groups is also an integer instead of boolean, but see #4038 for that.)
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 3, 2019 at 17:28 UTC (comment 1)

Done in the 3997_cleanup branch.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 3, 2019 at 17:29 UTC

  • Blocked by set to #3997

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 15, 2019 at 17:05 UTC (comment 3)

  • Milestone changed from Future Releases to 4.8.24
  • Votes set to committed-master

Fixed as [b2141c0].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 15, 2019 at 17:05 UTC

  • Blocked by #3997 deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 15, 2019 at 17:07 UTC (comment 5)

  • Resolution set to fixed
  • Status changed from new to closed

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 21, 2019 at 12:29 UTC (comment 6)

Small fix is [9ede2fa].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.24
Development

No branches or pull requests
1 participant
@mc-butler