Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MC fail to build with only SFTP network VFS future enabled #4420

Closed
mc-butler opened this issue Dec 13, 2022 · 6 comments
Closed

MC fail to build with only SFTP network VFS future enabled #4420

mc-butler opened this issue Dec 13, 2022 · 6 comments
Assignees
@aborodin
Labels
area: build Build system and (cross-)compilation prio: medium Has the potential to affect progress
Milestone
4.8.29

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4420
Reporter Bishop (bishop-mc@….org)

MC fail to build with futures like it:
"--enable-vfs-cpio --enable-vfs-tar --enable-vfs-sfs --enable-vfs-sftp --enable-vfs-extfs --disable-vfs-ftp --disable-vfs-smb --disable-vfs-fish --disable-vfs-undelfs"

The source of problem: no define ENABLE_VFS_NET with this params.

One point, that must be fixed: one of last lines m4.include/mc-vfs.m4 must be chaged to "if test x"$enable_vfs_ftp" = x"yes" -o x"$enable_vfs_sftp" = x"yes" -o x"$enable_vfs_fish" = x"yes"; then"

But there is no enough, somewhere else must be added this define for C compiler.

P.S. This problem confirmed in 4.8.26, 4.8.27 and 4.8.28 and looks like it is exist in trunk too.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 13, 2022 at 18:54 UTC (comment 1)

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Component changed from mc-core to mc-vfs

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 14, 2022 at 7:15 UTC (comment 2)

  • Component changed from mc-vfs to compilation

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 18, 2022 at 16:01 UTC (comment 3)

  • Branch state changed from no branch to on review

Branch: 4420_sftp_network_vfs
[ebb475f02dd350bf8366fde3523a4a92ebd067f2]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 30, 2022 at 5:09 UTC (comment 4)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 30, 2022 at 5:10 UTC (comment 5)

  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master
  • Status changed from accepted to testing
  • Branch state changed from approved to merged

Merged to master: [5583c3d].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 30, 2022 at 5:12 UTC (comment 6)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: build Build system and (cross-)compilation prio: medium Has the potential to affect progress
Milestone
4.8.29
Development

No branches or pull requests
2 participants
@aborodin @mc-butler