Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release mc-4.8.30 #4426

Closed
mc-butler opened this issue Jan 14, 2023 · 31 comments
Closed

Prepare for release mc-4.8.30 #4426

mc-butler opened this issue Jan 14, 2023 · 31 comments
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.30

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4426
Reporter zaytsev (@zyv)

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 14, 2023 at 19:35 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 22, 2023 at 9:44 UTC (comment 1)

Branch: 4426_cleanup
Initial [70a4ff6d55c074929cf239acfd9ba5acbf343cad]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 29, 2023 at 8:28 UTC (comment 2)

  • Version set to master

Merged to master: [8a91de7].

git log pretty=oneline a01fe3889..8a91de70c

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 6, 2023 at 18:09 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 3, 2023 at 13:47 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 5, 2023 at 17:19 UTC (comment 4)

mc-4426-fix-implicit-function-declaration-warning.patch​: applied.

Branch: 4426_cleanup
Initial [728f5c1b0d5619b9599470b298b2198e899146b3]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 19, 2023 at 17:42 UTC (comment 5)

Merge to master: [be3822c].

git log --pretty=oneline d845d0dc..be3822caf

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 19, 2023 at 17:44 UTC

(In #4438) [b7e4fb9]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 26, 2023 at 10:35 UTC (comment 7)

Branch: 4426_cleanup
Initial [ba1eb39e5db0ba54f02061da1eb0e6c38753946d]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 21, 2023 at 14:47 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 21, 2023 at 14:47 UTC (comment 8)

Added patch from closed GitHub PR.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 21, 2023 at 17:54 UTC (comment 9)

pr-164-add-dylib-support.patch​: applied.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 22, 2023 at 6:13 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 22, 2023 at 6:13 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 22, 2023 at 6:13 UTC (comment 10)

Two more trivial patches from GitHub added.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 22, 2023 at 19:08 UTC (comment 11)

pr-182-syntax-update-1.patch​: applied
pr-181-syntax-update-2.patch​: applied

@mc-butler
Copy link
Author

Changed by ukr (@ePubRepo) on May 22, 2023 at 21:04 UTC

  • Blocked by set to #4467

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 24, 2023 at 17:08 UTC

  • Blocked by #4467 deleted

(In #4467) TL;DR.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 28, 2023 at 16:04 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 28, 2023 at 16:09 UTC (comment 14)

Added a patch from GitHub to highlight *.zsh files as shell scripts.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 28, 2023 at 16:25 UTC (comment 15)

pr-168.patch​: applied.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 4, 2023 at 18:43 UTC (comment 16)

  • Votes set to committed-master

Merged to master: [04b3763].

git log --oneline 7111f8aa3..04b37639a

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 6, 2023 at 14:01 UTC (comment 17)

Got two warnings during the build on master:

../../../lib/tty/color-internal.c: In function 'tty_color_get_name_by_index':
../../../lib/tty/color-internal.c:187:34: warning: '%d' directive writing between 1 and 11 bytes into a region of size 4 [-Wformat-overflow=]
  187 |             sprintf (name, "color%d", idx);
      |                                  ^~
../../../lib/tty/color-internal.c:187:28: note: directive argument in the range [-2147483648, 255]
  187 |             sprintf (name, "color%d", idx);
      |                            ^~~~~~~~~
../../../lib/tty/color-internal.c:187:13: note: 'sprintf' output between 7 and 17 bytes into a destination of size 9
  187 |             sprintf (name, "color%d", idx);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../../../src/vfs/tar/tar-sparse.c: In function 'pax_decode_header':
../../../../src/vfs/tar/tar.c: In function 'tar_free_inode':
../../../../src/vfs/tar/tar.c:522:35: warning: unused parameter 'me' [-Wunused-parameter]
  522 | tar_free_inode (struct vfs_class *me, struct vfs_s_inode *ino)
      |                 ~~~~~~~~~~~~~~~~~~^~
../../../../src/vfs/tar/tar-sparse.c:697:50: warning: comparison of integer expressions of different signedness: '__off_t' {aka 'long int'} and 'long unsigned int' [-Wsign-compare]
  697 |                 || file->stat_info->stat.st_size < sp.offset + u)
      |

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 6, 2023 at 15:41 UTC (comment 18)

Built and pushed rc1 tarball. We really need to do something about Travis now :( noticed that CI hasn't been run since January...

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 6, 2023 at 18:16 UTC (comment 17.19)

Replying to zaytsev:

Got two warnings during the build on master:

Will be fixed in the next cleanup after release.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 7, 2023 at 15:24 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 7, 2023 at 15:27 UTC (comment 20)

I've got reply from support and hopefully Travis builds will be working again, but now it complains about 1) warnings and 2) indentation. See screenshot.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 12, 2023 at 18:17 UTC (comment 21)

  CC       tar-sparse.lo
../../../../src/vfs/tar/tar-sparse.c: In function ‘pax_decode_header’:
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
 #define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
                                                       ^
../../../../src/vfs/tar/tar-sparse.c:156:6: note: in definition of macro ‘_GL_ADD_OVERFLOW’
    ((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max)                 \
      ^
../../../../src/vfs/tar/tar-sparse.c:110:6: note: in expansion of macro ‘EXPR_SIGNED’
     (EXPR_SIGNED (e)                                                    \
      ^
../../../../src/vfs/tar/tar-sparse.c:124:23: note: in expansion of macro ‘_GL_INT_MINIMUM’
                       _GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)),         \
                       ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:156:11: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    ((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max)                 \
           ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:128:10: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
     ((b) < 0                                                            \
          ^
../../../../src/vfs/tar/tar-sparse.c:156:17: note: in expansion of macro ‘INT_ADD_RANGE_OVERFLOW’
    ((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max)                 \
                 ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
 #define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
                                                       ^
../../../../src/vfs/tar/tar-sparse.c:129:18: note: in definition of macro ‘INT_ADD_RANGE_OVERFLOW’
         ? (a) < (min) - (b)                                             \
                  ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:110:6: note: in expansion of macro ‘EXPR_SIGNED’
     (EXPR_SIGNED (e)                                                    \
      ^
../../../../src/vfs/tar/tar-sparse.c:124:23: note: in expansion of macro ‘_GL_INT_MINIMUM’
                       _GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)),         \
                       ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
 #define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
                                                       ^
../../../../src/vfs/tar/tar-sparse.c:130:12: note: in definition of macro ‘INT_ADD_RANGE_OVERFLOW’
         : (max) - (b) < (a))
            ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:114:6: note: in expansion of macro ‘EXPR_SIGNED’
     (EXPR_SIGNED (e)                                                    \
      ^
../../../../src/vfs/tar/tar-sparse.c:125:23: note: in expansion of macro ‘_GL_INT_MAXIMUM’
                       _GL_INT_MAXIMUM (_GL_INT_CONVERT (a, b)))
                       ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:158:11: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
     : (b) < 0 ? (a) <= (a) + (b)                                        \
           ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW���
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
cc1: all warnings being treated as errors

I don't want modify the code from GNU tar and gnulib to pacify GCC. What about of use

#pragma GCC diagnostic ignored "-Wtype-limits"

in tar-sparse.c?

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 12, 2023 at 19:44 UTC (comment 22)

Well, one could try to send a path to tar and gnulib people, but if you can't be bothered, then I think a pragma is OK to silence warnings for stolen code. If we start modifying it again, then updating will become more difficult... I think that it was quite a lot of work for you already to bring our tar implementation up to date.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 13, 2023 at 19:31 UTC (comment 23)

  • Resolution set to fixed
  • Status changed from new to closed

prepare repository for release
download PO-translations from Transifex
store translations in git repo
download the hint translations from Transifex
store translations in git repo

done

create new NEWS wiki page

NEWS-4.8.31

add content of current NEWS wiki page to the doc/NEWS
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files
make checksums for archives
upload source packages and checksums
run ssh midnightcommander@...
update Wiki start page with latest release number
write an announcement
close ticket for release
close current milestone

done

create new ticket

#4490

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 28, 2024 at 7:48 UTC (comment 24)

#168 was pulled in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.30
Development

No branches or pull requests
1 participant
@mc-butler