Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skin julia256.ini: Fix visual inconsistencies #4441

Closed
mc-butler opened this issue Feb 12, 2023 · 4 comments
Closed

Skin julia256.ini: Fix visual inconsistencies #4441

mc-butler opened this issue Feb 12, 2023 · 4 comments
Assignees
@aborodin
Labels
area: skin Theming support and skin files prio: low Minor problem or easily worked around
Milestone
4.8.30

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4441
Reporter proski

Set "disabled" background to "lightgray" for consistency with the dialog background. The inconsistent background can be seen in the file search dialog with an empty search string.

The hotkeys in dialogs were impossible to distinguish from other text. Make them red for consistency with the buttonbar.

Show changed lines in diffs in black on cyan. Blue on cyan is hard to see, such color combination is not used elsewhere in the skin, which promises "good contrast".

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by proski on Feb 12, 2023 at 8:41 UTC

Patch

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 12, 2023 at 10:38 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.30
  • Status changed from new to accepted
  • Owner set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 12, 2023 at 10:45 UTC (comment 2)

  • Votes set to committed-master
  • Status changed from accepted to testing
  • Resolution set to fixed

Thanks!
Applied as [a6fc94f].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 12, 2023 at 10:47 UTC (comment 3)

  • Status changed from testing to closed

@mc-butler mc-butler mentioned this issue Feb 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: skin Theming support and skin files prio: low Minor problem or easily worked around
Milestone
4.8.30
Development

No branches or pull requests
2 participants
@aborodin @mc-butler