Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in History #1936

Closed
mc-butler opened this issue Jan 5, 2010 · 7 comments
Closed

Segfault in History #1936

mc-butler opened this issue Jan 5, 2010 · 7 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.0 Reproducible in version 4.7.0
Milestone
4.7.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1936
Reporter ralesk (ralesk@….hu)

I noticed that if there’s only one entry in an input history (in my case it was Right/Listing mode.../Mini info), pressing M-p (“Previous history item”) would cause a segmentation fault — I guess it was trying to access the “-1st” element of the array or linked list or whatever, and poked at a bad place this way. Pressing M-n (“Next history item”) emptied the input field and added said empty line to the history, and with two items I couldn’t notice this issue.

Using 4.7 (not 4.7.0.1).
@mc-butler
Copy link
Author

Changed by ralesk (ralesk@….hu) on Jan 5, 2010 at 2:48 UTC (comment 1)

  • Version changed from version not selected to 4.7.0

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 5, 2010 at 8:29 UTC (comment 2)

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Severity changed from no branch to on review

Thanks for the bugreport!

Created branch 1936_history_segfault. Parent branch is master.
[7f17e65831fc8ea85ee26d512a1cce0987d749a7]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 5, 2010 at 8:31 UTC (comment 3)

  • Milestone changed from 4.7 to 4.7.1

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 6, 2010 at 11:55 UTC (comment 4)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 6, 2010 at 12:05 UTC (comment 5)

  • Votes changed from angel_il to angel_il slavazanko
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 6, 2010 at 12:44 UTC (comment 6)

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Votes changed from angel_il slavazanko to commited-master
  • Severity changed from approved to merged

Merged to master.
[6d9e319]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 6, 2010 at 13:06 UTC (comment 7)

  • Status changed from testing to closed

Cheery-picked into 4.7.0-stable
[1d1b601]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.0 Reproducible in version 4.7.0
Milestone
4.7.1
Development

No branches or pull requests
2 participants
@aborodin @mc-butler