Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bogus string in confirmation config dialog #2271

Closed
mc-butler opened this issue Jul 11, 2010 · 15 comments
Closed

bogus string in confirmation config dialog #2271

mc-butler opened this issue Jul 11, 2010 · 15 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.8.7 Reproducible in version 4.8.7
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2271
Reporter ossi (@ossilator)
Mentions zaytsev (@zyv), egmont@….com (@egmontkob)

f9 -> o -> o

i18n context information seems to have trickled into the user-visible description strings of the checkboxes.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 11, 2010 at 10:14 UTC (comment 1)

  • Cc set to zaytsev

I don't see anything abnormal here on master (en_US locale). If you are talking about the "confirm" words that got removed, this happened long time ago ([2a8817b]) and seemingly on purpose.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jul 11, 2010 at 10:30 UTC (comment 2)

bravo, you got the right commit. though a bit differently than you thought ... ;)

i'm talking about the "Confirmation|" prefixes. they actually show up here.
maybe that's because i'm building with --disable-nls.
typically, i18n context information would be supplied as a separate parameter to the function/macro. that wouldn't rely on some string mangling magic being built into gettext ...

i've seen this problem in some more places, but i couldn't find any of them right now. maybe it was fixed meanwhile or they are more hidden than i remembered.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 11, 2010 at 10:52 UTC (comment 3)

  • Owner set to andrew_b
  • Status changed from new to assigned

The fact that you used non-default ./configure parameters was crucial. Yes, this is yet unfixed remnant from the time, the prefixes were introduces (earlier same issue was fixed for copy/move dialogs).

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 11, 2010 at 10:53 UTC (comment 4)

  • Milestone changed from 4.7 to 4.7.4

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 11, 2010 at 11:04 UTC (comment 5)

  • Severity changed from no branch to on review
  • Keywords set to stable-candidate

Created 2271_confirmation_dialog_i18n branch. Parent branch is master.
[95fc5e37d3dc0acfbf610e35da0d40fcff480f07]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 11, 2010 at 11:58 UTC (comment 6)

  • Votes set to zaytsev

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jul 19, 2010 at 11:59 UTC (comment 7)

  • Severity changed from on review to approved
  • Votes changed from zaytsev to zaytsev slavazanko

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 19, 2010 at 12:31 UTC (comment 8)

  • Status changed from assigned to testing
  • Keywords stable-candidate deleted
  • Resolution set to fixed
  • Votes changed from zaytsev slavazanko to committed-master committed-stable
  • Severity changed from approved to merged

Merged to master.
[502a28d]

Cherry-picked to 4.7.0-stable.
chamgeset:9cab5aaa890dbb51225a6b1da08e6a4f594b063a

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 19, 2010 at 12:31 UTC (comment 9)

  • Status changed from testing to closed

Cherry-picked to 4.7.0-stable.
[9cab5aa]

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on Sep 3, 2013 at 18:16 UTC (comment 10)

  • Cc changed from zaytsev to zaytsev, egmont@….com
  • Milestone changed from 4.7.4 to 4.8.11
  • Status changed from closed to reopened
  • Version changed from master to 4.8.7
  • Branch state set to no branch
  • Resolution fixed deleted

This is buggy again since 4.8.7.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 4, 2013 at 5:09 UTC (comment 11)

  • Branch state changed from no branch to on review
  • Votes committed-master committed-stable deleted

Branch: 2271_confirmation_dialog_i18n
[f7e12a620da44b89ab083bb012d743d172307c82]

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on Sep 4, 2013 at 9:45 UTC (comment 12)

Thanks! :)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 9, 2013 at 10:02 UTC (comment 13)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 12, 2013 at 12:33 UTC (comment 14)

  • Votes changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 12, 2013 at 14:21 UTC (comment 15)

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Branch state changed from approved to merged
  • Votes changed from slavazanko angel_il to committed-master

Merged to master: [e23239b].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.8.7 Reproducible in version 4.8.7
Development

No branches or pull requests

2 participants