Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] fix memleak at filemanager/find.c:panel_operate() #3461

Closed
mc-butler opened this issue May 7, 2015 · 4 comments
Closed

[patch] fix memleak at filemanager/find.c:panel_operate() #3461

mc-butler opened this issue May 7, 2015 · 4 comments
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.15

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3461
Reporter and

fix memleak at filemanager/find.c:panel_operate()

panel_operate() allocate source_with_path_str but never freed

found by LeakSanitizer

Direct leak of 128 byte(s) in 4 object(s) allocated from:

#0 0x4d60a5 in realloc (/tmp/portage/app-misc/mc-9999/work/mc-9999/src/mc+0x4d60a5)
#1 0x7f15c5ba190d in g_realloc (/usr/lib64/libglib-2.0.so.0+0x6790d)
#2 0x7f15c5bcb493 in g_string_sized_new (/usr/lib64/libglib-2.0.so.0+0x91493)
#3 0x6076ba in strutils_unescape /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/strutil/strescape.c:111:11
#4 0x7cc719 in panel_operate /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/file.c:2982:29
#5 0x7a702b in copy_cmd /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/cmd.c:795:9
#6 0x5a64cb in midnight_execute_cmd /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/midnight.c:1144:9
#7 0x519c47 in buttonbar_callback /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/buttonbar.c:172:42
#8 0x531415 in dlg_try_hotkey /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:464:23
#9 0x52fbfa in dlg_key_event /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:509:19
#10 0x530546 in frontend_dlg_run /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:570:9
#11 0x530165 in dlg_run /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/widget/dialog.c:1267:5
#12 0x5a1cca in do_nc /tmp/portage/app-misc/mc-9999/work/mc-9999/src/filemanager/midnight.c:1762:9
#13 0x4fa3e8 in main /tmp/portage/app-misc/mc-9999/work/mc-9999/src/main.c:418:21
#14 0x7f15c4c72133 in libc_start_main (/lib64/libc.so.6+0x20133)
#15 0x44ed96 in _start (/tmp/portage/app-misc/mc-9999/work/mc-9999/src/mc+0x44ed96)

Signed-off-by: Andreas Mohr <​and@gmx.li>

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by and on May 7, 2015 at 17:51 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 9, 2015 at 13:35 UTC

  • Blocked by set to #3420

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 24, 2015 at 15:14 UTC (comment 2)

  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Status changed from new to closed
  • Milestone changed from Future Releases to 4.8.15

Thanks!
Applied as [8566e10].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 24, 2015 at 15:26 UTC

  • Blocked by #3420 deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.15
Development

No branches or pull requests
1 participant
@mc-butler